[NavigationDrawer] Allow users to scroll to dismiss on lower resolution devices. #8503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bazel detected changes to the following targets: |
|
bazel detected changes to the following targets: |
|
Could you please provide some documentation around the addition to explain why we need this change and what it means |
|
@yarneo I've added documentation please let me know if further clarification is needed. |
|
Just want to clarify: Do you believe maybe that your added change is possibly the only needed conditional and |
| @@ -641,7 +641,8 @@ - (void)updateViewWithContentOffset:(CGPoint)contentOffset { | |||
| transitionRatio:transitionPercentage]; | |||
|
|
|||
| [self updateDrawerState:transitionPercentage]; | |||
| self.currentlyFullscreen = self.contentReachesFullscreen && headerTransitionToTop >= 1; | |||
| self.currentlyFullscreen = | |||
| self.contentReachesFullscreen && contentOffset.y > 0; | |||
There was a problem hiding this comment.
clang-format suggested the following change:
- self.currentlyFullscreen =
- self.contentReachesFullscreen && contentOffset.y > 0;
+ self.currentlyFullscreen = self.contentReachesFullscreen && contentOffset.y > 0;
|
@yarneo |
yarneo
approved these changes
Sep 26, 2019
|
@yarneo I tested on high res devices and it looks good to me. |
codeman7
added a commit
that referenced
this pull request
Sep 26, 2019
In #8503 this line was removed but after further testing when the contentViewController expands it's preferredContentSize this causes a regression in the header behavior. With this line added back into the check this behavior is fixed.
ggdiez
pushed a commit
to solidgear/material-components-ios
that referenced
this pull request
Sep 27, 2019
…on devices. (material-components#8503) This change allows `currentlyFullscreen` property on [`MDCBottomDrawerContainerViewController`](https://github.com/material-components/material-components-ios/blob/develop/components/NavigationDrawer/src/private/MDCBottomDrawerContainerViewController.m) to become `NO` on lower resolution devices. Currently this property is always `NO`. This doesn't allow the code within `- (void)scrollViewWillEndDragging:withVelocity:targetContentOffset:` to be executed. ## Testing 1. Set `preferredContentSize` on the headerVC of a Navigation Drawer example to 80. 2. Set `preferredContentSize` on the contentVC of the same Navigation Drawer example to a value less than 240. 3. Open the example on a iPhoneSE 4. Rotate to landscape. 5. Try to swipe to dismiss the drawer. Closes #8454
ggdiez
pushed a commit
to solidgear/material-components-ios
that referenced
this pull request
Sep 27, 2019
…omponents#8514) In material-components#8503 this line was removed but after further testing when the contentViewController expands it's preferredContentSize this causes a regression in the header behavior. With this line added back into the check this behavior is fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows
currentlyFullscreenproperty onMDCBottomDrawerContainerViewControllerto becomeNOon lower resolution devices. Currently this property is alwaysNO. This doesn't allow the code within- (void)scrollViewWillEndDragging:withVelocity:targetContentOffset:to be executed.Testing
preferredContentSizeon the headerVC of a Navigation Drawer example to 80.preferredContentSizeon the contentVC of the same Navigation Drawer example to a value less than 240.Closes #8454