Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TextFields] Update character count announcement in MDCTextInputControllerFullWidth #8789

Merged
merged 1 commit into from
Nov 12, 2019
Merged

[TextFields] Update character count announcement in MDCTextInputControllerFullWidth #8789

merged 1 commit into from
Nov 12, 2019

Conversation

bryanoltman
Copy link
Contributor

Update VoiceOver announcement in MDCTextInputControllerFullWidth to match that of MDCTextInputControllerBase.m

Fixes #7624

@material-automation
Copy link

material-automation commented Nov 12, 2019 •
edited

bazel detected changes to the following targets:

//components/Chips:snapshot_tests
//components/Chips:snapshot_tests_test_bundle
//components/Chips:unit_tests
//components/Chips:unit_tests_IPAD_PRO_12_9_IN_9_3
//components/Chips:unit_tests_IPAD_PRO_12_9_IN_9_3_test_bundle
//components/Chips:unit_tests_IPHONE_7_PLUS_IN_10_3
//components/Chips:unit_tests_IPHONE_7_PLUS_IN_10_3_test_bundle
//components/Chips:unit_tests_environment
//components/Chips:unit_tests_environment_test_bundle
//components/TextFields:snapshot_tests
//components/TextFields:snapshot_tests_test_bundle
//components/TextFields:unit_tests
//components/TextFields:unit_tests_IPAD_PRO_12_9_IN_9_3
//components/TextFields:unit_tests_IPAD_PRO_12_9_IN_9_3_test_bundle
//components/TextFields:unit_tests_IPHONE_7_PLUS_IN_10_3
//components/TextFields:unit_tests_IPHONE_7_PLUS_IN_10_3_test_bundle
//components/TextFields:unit_tests_IPHONE_X_IN_11_0
//components/TextFields:unit_tests_IPHONE_X_IN_11_0_test_bundle

@wenyuzhang666 wenyuzhang666 requested a review from a team November 12, 2019 22:01
@bryanoltman bryanoltman merged commit 118dfa3 into material-components:develop Nov 12, 2019
@bryanoltman bryanoltman deleted the issue-7624-text-field-announcement branch November 12, 2019 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenyuzhang666 wenyuzhang666 wenyuzhang666 approved these changes

@yarneo yarneo Awaiting requested review from yarneo

@andrewoverton andrewoverton Awaiting requested review from andrewoverton

Assignees
No one assigned
Labels
Accessibility cla: yes [TextFields]
Projects
None yet
Milestone
No milestone
4 participants
@bryanoltman @material-automation @wenyuzhang666 @googlebot