[TextFields] Add identity check in -setTextColor: in MDCTextField #9480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How did you verify that this fixes the issue? |
|
I built the app and added a bunch of breakpoints and eventually zeroed in on which method calls were necessary to trigger the infinite loop and then found a way to make it so they weren't made again and again and again. It's bizarre. There's some interplay between the layout process of the text field and some "safeAreaInsetsDidChange" logic in flexible header that is just no good! |
|
Oh and I updated the PR description to link to the bug which links to some before and after gifs |
|
bazel detected changes to the following targets: |
bryanoltman
approved these changes
Jan 23, 2020
|
Good idea, I'll do that |
andrewoverton
added a commit
that referenced
this pull request
Jan 24, 2020
) This PR adds an identity check in `-setTextColor:` in MDCTextField. This identity check short circuits an infinite loop triggered by `-setTextColor:` under certain mysterious circumstances involving the MDCTextField layout pass and MDCFlexibleHeaderView KVO stuff surrounding safeAreaInset changes. I don't fully understand what's going on tbh :) The internal bug ([b/148159587](http://b/148159587)) has links to before and after gifs in the comments. Closes #9470 ### Update: The internal client who reported the bug was unable to reproduce it with these changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an identity check in
-setTextColor:in MDCTextField. This identity check short circuits an infinite loop triggered by-setTextColor:under certain mysterious circumstances involving the MDCTextField layout pass and MDCFlexibleHeaderView KVO stuff surrounding safeAreaInset changes. I don't fully understand what's going on tbh :)The internal bug (b/148159587) has links to before and after gifs in the comments.
Closes #9470
Update: The internal client who reported the bug was unable to reproduce it with these changes.