Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dialogs] Consider all actions alignments for vertical layouts #9804

Merged
merged 2 commits into from
Feb 28, 2020

Conversation

galiak11
Copy link
Contributor

@galiak11 galiak11 commented Feb 27, 2020

Description

Implement leading, center, trailing and justified alignment for actions in vertical layout.
When there is not enough space for action to align horizontally, they automatically switch to vertical layout. The default alignment in vertical layout is centered, unless configured by actionsHorizontalAlignmentInVerticalLayout.

Note that actions alignment API is still under development and is in a private header.

Issue

b/122654717, cl/297554381

@galiak11 galiak11 changed the base branch from stable to develop February 27, 2020 11:25
@galiak11 galiak11 force-pushed the AC12DF34388B9EAF19E84A511B48793B branch from 9986d25 to f438c66 Compare February 27, 2020 11:57
@material-automation
Copy link

material-automation commented Feb 27, 2020

bazel detected changes to the following targets:

//catalog:MDCCatalog
//catalog:MDCCatalog.apple_binary
//catalog:MDCCatalog.swift_runtime_linkopts
//catalog:MDCCatalogLib
//components/Dialogs:ColorThemer
//components/Dialogs:DialogThemer
//components/Dialogs:Dialogs
//components/Dialogs:ObjcExamples
//components/Dialogs:SwiftExamples
//components/Dialogs:Theming
//components/Dialogs:TypographyThemer
//components/Dialogs:snapshot_test_lib
//components/Dialogs:snapshot_tests
//components/Dialogs:snapshot_tests.swift_runtime_linkopts
//components/Dialogs:snapshot_tests_test_binary
//components/Dialogs:snapshot_tests_test_bundle
//components/Dialogs:unit_test_sources
//components/Dialogs:unit_test_swift_sources
//components/Dialogs:unit_tests
//components/Dialogs:unit_tests_IPAD_PRO_12_9_IN_9_3
//components/Dialogs:unit_tests_IPAD_PRO_12_9_IN_9_3.swift_runtime_linkopts
//components/Dialogs:unit_tests_IPAD_PRO_12_9_IN_9_3_test_binary
//components/Dialogs:unit_tests_IPAD_PRO_12_9_IN_9_3_test_bundle
//components/Dialogs:unit_tests_IPHONE_7_PLUS_IN_10_3
//components/Dialogs:unit_tests_IPHONE_7_PLUS_IN_10_3.swift_runtime_linkopts
//components/Dialogs:unit_tests_IPHONE_7_PLUS_IN_10_3_test_binary
//components/Dialogs:unit_tests_IPHONE_7_PLUS_IN_10_3_test_bundle
//components/Dialogs:unit_tests_environment
//components/Dialogs:unit_tests_environment.swift_runtime_linkopts
//components/Dialogs:unit_tests_environment_test_binary
//components/Dialogs:unit_tests_environment_test_bundle

@galiak11 galiak11 force-pushed the AC12DF34388B9EAF19E84A511B48793B branch from f438c66 to 429f4ff Compare February 27, 2020 12:02
@galiak11 galiak11 force-pushed the AC12DF34388B9EAF19E84A511B48793B branch 2 times, most recently from fa1f4e7 to af16dc6 Compare February 27, 2020 16:14
Copy link
Contributor

@andrewoverton andrewoverton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM under the same conditions as #9805

@galiak11 galiak11 force-pushed the AC12DF34388B9EAF19E84A511B48793B branch from af16dc6 to 0dd1c93 Compare February 28, 2020 12:15
@galiak11 galiak11 requested a review from a team as a code owner February 28, 2020 21:30
@galiak11 galiak11 merged commit b32c232 into develop Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants