-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dialogs] Consider all actions alignments for vertical layouts #9804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galiak11
force-pushed
the
AC12DF34388B9EAF19E84A511B48793B
branch
from
February 27, 2020 11:57
9986d25
to
f438c66
Compare
components/Dialogs/src/private/MDCAlertControllerView+Private.m
Outdated
Show resolved
Hide resolved
components/Dialogs/src/private/MDCAlertControllerView+Private.m
Outdated
Show resolved
Hide resolved
bazel detected changes to the following targets:
|
galiak11
force-pushed
the
AC12DF34388B9EAF19E84A511B48793B
branch
from
February 27, 2020 12:02
f438c66
to
429f4ff
Compare
galiak11
force-pushed
the
AC12DF34388B9EAF19E84A511B48793B
branch
2 times, most recently
from
February 27, 2020 16:14
fa1f4e7
to
af16dc6
Compare
andrewoverton
approved these changes
Feb 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM under the same conditions as #9805
iberezan
approved these changes
Feb 27, 2020
galiak11
force-pushed
the
AC12DF34388B9EAF19E84A511B48793B
branch
from
February 28, 2020 12:15
af16dc6
to
0dd1c93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement leading, center, trailing and justified alignment for actions in vertical layout.
When there is not enough space for action to align horizontally, they automatically switch to vertical layout. The default alignment in vertical layout is centered, unless configured by actionsHorizontalAlignmentInVerticalLayout.
Note that actions alignment API is still under development and is in a private header.
Issue
b/122654717, cl/297554381