Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chips] In MDCChipField, account for horizontal padding when calculating available width for text field #9841

Conversation

bryanoltman
Copy link
Contributor

This change addresses an issue introduced in #9837, where the calculation of available width for the text field did not take into account the chip field's horizontal insets.

@bryanoltman bryanoltman requested review from jverkoey and a team March 5, 2020 16:07
@material-automation
Copy link

material-automation commented Mar 5, 2020

bazel detected changes to the following targets:

//components/Chips:Chips
//components/Chips:ObjcExamples
//components/Chips:SwiftExamples
//components/Chips:Theming
//components/Chips:privateHeaders
//components/Chips:snapshot_test_lib
//components/Chips:snapshot_tests
//components/Chips:snapshot_tests.swift_runtime_linkopts
//components/Chips:snapshot_tests_test_binary
//components/Chips:snapshot_tests_test_bundle
//components/Chips:unit_test_sources
//components/Chips:unit_test_swift_sources
//components/Chips:unit_tests
//components/Chips:unit_tests_IPAD_PRO_12_9_IN_9_3
//components/Chips:unit_tests_IPAD_PRO_12_9_IN_9_3.swift_runtime_linkopts
//components/Chips:unit_tests_IPAD_PRO_12_9_IN_9_3_test_binary
//components/Chips:unit_tests_IPAD_PRO_12_9_IN_9_3_test_bundle
//components/Chips:unit_tests_IPHONE_7_PLUS_IN_10_3
//components/Chips:unit_tests_IPHONE_7_PLUS_IN_10_3.swift_runtime_linkopts
//components/Chips:unit_tests_IPHONE_7_PLUS_IN_10_3_test_binary
//components/Chips:unit_tests_IPHONE_7_PLUS_IN_10_3_test_bundle
//components/Chips:unit_tests_environment
//components/Chips:unit_tests_environment.swift_runtime_linkopts
//components/Chips:unit_tests_environment_test_binary
//components/Chips:unit_tests_environment_test_bundle
//components/schemes/Shape:ObjcExamples

@bryanoltman bryanoltman merged commit 2ceeb0a into material-components:develop Mar 5, 2020
@bryanoltman bryanoltman deleted the MDCChipField-horizontal-padding branch March 5, 2020 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants