fix(select): pass state.value to NativeControl as prop.value (#726)

material-components · Mar 18, 2019 · 09ad132 · 09ad132
1 parent 619d12c
commit 09ad132
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/packages/select/index.tsx b/packages/select/index.tsx
@@ -201,6 +201,7 @@ export default class Select extends React.Component<SelectProps, SelectState> {
       outlined,
       onChange,
       ref,
+      value,
       /* eslint-enable */
       ...otherProps
     } = this.props;
@@ -212,6 +213,7 @@ export default class Select extends React.Component<SelectProps, SelectState> {
         handleDisabled={this.setDisabled}
         onChange={this.onChange}
         setRippleCenter={this.setRippleCenter}
+        value={this.state.value}
         {...otherProps}
       >
         {this.renderOptions()}

diff --git a/test/unit/select/index.test.tsx b/test/unit/select/index.test.tsx
@@ -205,6 +205,15 @@ test('passes classNames to NativeControl through props.nativeControlClassName',
   assert.isTrue(wrapper.childAt(0).hasClass(className));
 });
 
+test('#NativeControl.value will update with Select.state.value', () => {
+  const wrapper = shallow<Select>(<Select label='my label' />);
+  const value = 'value';
+  wrapper.setState({value});
+
+  assert.equal(wrapper.state().value, value);
+  assert.equal(wrapper.childAt(0).props().value, value);
+});
+
 test('#NativeControl.onChange will update state.value', () => {
   const wrapper = shallow<Select>(<Select label='my label' />);
   const evt = {target: {value: 'orange'}};