fix(select): className option is passed to select and overrides selec…

…tClassName (#872)
material-components · May 30, 2019 · 6e2aac1 · 6e2aac1
1 parent 40ca635
commit 6e2aac1
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/packages/select/index.tsx b/packages/select/index.tsx
@@ -343,6 +343,7 @@ export default class Select<
     const {
       selectClassName,
       /* eslint-disable */
+      className,
       floatingLabelClassName,
       lineRippleClassName,
       notchedOutlineClassName,

diff --git a/test/unit/select/index.test.tsx b/test/unit/select/index.test.tsx
@@ -403,6 +403,16 @@ test('renders BaseSelect for select', () => {
   );
 });
 
+test('does not pass className to BaseSelect', () => {
+  const wrapper = shallow(<Select label='my label' className="container-class" />);
+  assert.equal(wrapper.childAt(0).childAt(1).prop('className'), "");
+});
+
+test('pass selectClassName to BaseSelect', () => {
+  const wrapper = shallow(<Select label='my label' selectClassName="select-class" />);
+  assert.equal(wrapper.childAt(0).childAt(1).prop('className'), "select-class");
+});
+
 test('renders FloatingLabel after BaseSelect if props.label exists', () => {
   const wrapper = shallow(<Select label='my label' />);
   assert.equal(