Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(select): className option is passed to select and overrides selectClassName #872

Merged
merged 2 commits into from May 23, 2019
Merged

fix(select): className option is passed to select and overrides selectClassName #872

merged 2 commits into from May 23, 2019

Conversation

gugu
Copy link
Contributor

@gugu gugu commented May 21, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented May 21, 2019 •
edited

Codecov Report

Merging #872 into rc0.13.0 will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           rc0.13.0     #872      +/-   ##
============================================
+ Coverage     93.98%   93.98%   +<.01%     
============================================
  Files            85       85              
  Lines          3575     3576       +1     
  Branches        560      560              
============================================
+ Hits           3360     3361       +1     
  Misses           90       90              
  Partials        125      125
Impacted Files Coverage Δ
packages/select/index.tsx 99.41% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7649f90...85f368d. Read the comment docs.

moog16
moog16 suggested changes May 21, 2019
View reviewed changes
Copy link
Contributor

@moog16 moog16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gugu thank you! Could you please add a unit test to prevent against this from happening again?

@moog16 moog16 changed the base branch from master to rc0.13.0 May 21, 2019 17:34
@gugu
Copy link
Contributor Author

gugu commented May 23, 2019

@moog16 done

moog16
moog16 approved these changes May 23, 2019
View reviewed changes
Copy link
Contributor

@moog16 moog16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! looks good

@moog16 moog16 merged commit 0a83e71 into material-components:rc0.13.0 May 23, 2019
moog16 pushed a commit that referenced this pull request May 30, 2019
@gugu
fix(select): className option is passed to select and overrides selec…
6e2aac1 
…tClassName (#872)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moog16 moog16 moog16 approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gugu @codecov-io @moog16 @googlebot