fix(list): renders a list with children which is not DOM (#674)

material-components · Feb 19, 2019 · e66a267 · e66a267
1 parent 9c7330b
commit e66a267
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/package.json b/package.json
@@ -76,6 +76,7 @@
     "@material/list": "^0.41.0",
     "@material/menu-surface": "^0.41.0",
     "@material/notched-outline": "^0.41.0",
+    "@material/radio": "^0.41.0",
     "@material/ripple": "^0.41.0",
     "@material/select": "^0.40.1",
     "@material/snackbar": "^0.43.0",

diff --git a/packages/list/index.tsx b/packages/list/index.tsx
@@ -67,7 +67,7 @@ function isReactText(element: any): element is React.ReactText {
 }
 
 function isListItem(element: any): element is ListItem {
-  return element.type === ListItem;
+  return element && element.type === ListItem;
 }
 
 export default class List<T extends HTMLElement = HTMLElement> extends React.Component<ListProps<T>, ListState> {

diff --git a/test/unit/list/index.test.tsx b/test/unit/list/index.test.tsx
@@ -402,3 +402,14 @@ test('renders a list with a nav tag', () => {
   const wrapper = shallow(<List tag='nav'>{children()}</List>);
   assert.equal(wrapper.type(), 'nav');
 });
+
+test('renders a list with children which is not DOM', () => {
+  const wrapper = shallow(<List>
+    {}
+    {false}
+    {'text'}
+    {null}
+    {undefined}
+  </List>);
+  assert.isTrue(wrapper.children().length === 1);
+});