Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(drawer): initialize foundation if props.open updates #427

Merged
merged 11 commits into from
Nov 17, 2018

Conversation

moog16
Copy link

@moog16 moog16 commented Nov 9, 2018

fixes #408

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@moog16 moog16 added this to the 0.7.0 milestone Nov 9, 2018
@moog16 moog16 changed the base branch from master to rc7.0 November 9, 2018 22:48
@codecov-io
Copy link

codecov-io commented Nov 9, 2018

Codecov Report

Merging #427 into rc7.0 will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##            rc7.0     #427      +/-   ##
==========================================
+ Coverage   96.65%   96.67%   +0.01%     
==========================================
  Files          59       59              
  Lines        1975     1984       +9     
  Branches      232      234       +2     
==========================================
+ Hits         1909     1918       +9     
  Misses         66       66
Impacted Files Coverage Δ
packages/drawer/index.js 97.64% <100%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a93d831...851150b. Read the comment docs.

@googlebot
Copy link

CLAs look good, thanks!

if (!(dismissible || modal)) return;

if ((changedToModal || changedToDismissible) && !this.foundation_) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if ((changedToModal || changedToDismissible) && !this.foundation_) {
if (!this.foundation_) {

If I'm understanding this right, it doesn't matter whether it was changed to modal/dismissible or if it was already modal/dismissible, but as long as it's modal/dismissible and doesn't have a foundation then we should initialize it, right?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modal has a different foundation from dismissible. So actually this might be incorrect

@moog16 moog16 merged commit f14121d into rc7.0 Nov 17, 2018
@moog16 moog16 deleted the fix/drawer/modal-to-permanent branch November 17, 2018 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants