-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(drawer): initialize foundation if props.open updates #427
Conversation
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
Codecov Report
@@ Coverage Diff @@
## rc7.0 #427 +/- ##
==========================================
+ Coverage 96.65% 96.67% +0.01%
==========================================
Files 59 59
Lines 1975 1984 +9
Branches 232 234 +2
==========================================
+ Hits 1909 1918 +9
Misses 66 66
Continue to review full report at Codecov.
|
CLAs look good, thanks! |
packages/drawer/index.js
Outdated
if (!(dismissible || modal)) return; | ||
|
||
if ((changedToModal || changedToDismissible) && !this.foundation_) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if ((changedToModal || changedToDismissible) && !this.foundation_) { | |
if (!this.foundation_) { |
If I'm understanding this right, it doesn't matter whether it was changed to modal/dismissible or if it was already modal/dismissible, but as long as it's modal/dismissible and doesn't have a foundation then we should initialize it, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modal has a different foundation from dismissible. So actually this might be incorrect
…aterial-components/material-components-web-react into fix/drawer/modal-to-permanent
…-components/material-components-web-react into fix/drawer/modal-to-permanent
fixes #408