feat(chips): typescript support #493
Conversation
This reverts commit d486cef.
| this.chipElement_ = el; | ||
| this.props.initRipple(el); | ||
| } | ||
| }; | ||
|
|
||
| get classes() { |
There was a problem hiding this comment.
This is an implied string return type. If you hover over it in vscode, you can see it being applied. Also we have inferredAny: false. So its built into our linter that this cannot happen.
packages/chips/ChipSet.tsx
Outdated
|
|
||
| constructor(props) { | ||
| export default class ChipSet extends React.Component<ChipSetProps, ChipSetState> { | ||
| checkmarkWidth_ = 0; |
There was a problem hiding this comment.
Same thing here, should this be marked private?
packages/chips/Chip.tsx
Outdated
| }; | ||
|
|
||
| export class Chip extends React.Component<ChipProps, ChipState> { | ||
| chipElement_: HTMLDivElement | null = null; |
There was a problem hiding this comment.
this is being used in the tests and cannot be private :(
|
|
||
| computeBoundingRect = (chipElement) => { | ||
| computeBoundingRect = (chipElement: HTMLDivElement) => { |
|
@rlfriedman updated! |
moog16
changed the base branch from
fix/coverage-typescript
to
feat/two-typescript
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
related #48