Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(text-field): uncomment test fixed from 0.35.0 #404

Merged
merged 7 commits into from Nov 9, 2018

Conversation

moog16
Copy link
Contributor

@moog16 moog16 commented Nov 1, 2018

No description provided.

@codecov-io
Copy link

codecov-io commented Nov 1, 2018

Codecov Report

Merging #404 into rc7.0 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            rc7.0     #404   +/-   ##
=======================================
  Coverage   96.14%   96.14%           
=======================================
  Files          55       55           
  Lines        1841     1841           
  Branches      214      214           
=======================================
  Hits         1770     1770           
  Misses         71       71

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5075cf2...6bf0798. Read the comment docs.

Copy link
Contributor

@bonniezhou bonniezhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this commented out in the first place?

@moog16
Copy link
Contributor Author

moog16 commented Nov 2, 2018

I think pre-v0.35.0 the logic wasn't there to support it. I can't remember :|

@moog16 moog16 changed the base branch from master to rc7.0 November 7, 2018 01:37
@moog16 moog16 closed this Nov 9, 2018
@moog16 moog16 reopened this Nov 9, 2018
@moog16 moog16 added this to the 0.7.0 milestone Nov 9, 2018
@moog16 moog16 merged commit 647ff52 into rc7.0 Nov 9, 2018
@moog16 moog16 deleted the fix/text-field/add-back-test branch November 9, 2018 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants