Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu surface are not removed from DOM on unmount #500

Closed
futurliberta opened this issue Dec 7, 2018 · 2 comments
Closed

Menu surface are not removed from DOM on unmount #500

futurliberta opened this issue Dec 7, 2018 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@futurliberta
Copy link

futurliberta commented Dec 7, 2018 •
edited

Hi,

On mount, MenuSurface components are moved to <body> but are not removed from DOM on unmount.
@moog16
Copy link
Contributor

moog16 commented Dec 7, 2018

This is actually a duplicate of this: #455. Your issue is actually more accurate. I will close #455.

Also marking this help wanted if you'd like to open a PR.

@moog16 moog16 added the help wanted Extra attention is needed label Dec 7, 2018
@moog16 moog16 mentioned this issue Dec 7, 2018
Closed
@moog16 moog16 mentioned this issue Jan 16, 2019
Closed
@moog16 moog16 mentioned this issue Feb 27, 2019
Merged
moog16 pushed a commit that referenced this issue Mar 15, 2019
fix(menu-surface): Hoist menu-surface via a portal (#500,#628) (#693)
b15c780
@moog16
Copy link
Contributor

moog16 commented Mar 15, 2019

Closed with #693

@moog16 moog16 closed this as completed Mar 15, 2019
moog16 pushed a commit that referenced this issue Mar 18, 2019
fix(menu-surface): Hoist menu-surface via a portal (#500,#628) (#693)
41d8750
moog16 pushed a commit that referenced this issue Mar 19, 2019
fix(menu-surface): Hoist menu-surface via a portal (#500,#628) (#693)
4f5164c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@moog16 @futurliberta