Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(button): typescript #508

Merged
merged 126 commits into from Dec 21, 2018
Merged

feat(button): typescript #508

merged 126 commits into from Dec 21, 2018

Conversation

moog16
Copy link
Contributor

@moog16 moog16 commented Dec 11, 2018

related #48

@moog16
Copy link
Contributor Author

moog16 commented Dec 18, 2018

@appsforartists I pushed updates except for React.Ref, which I responded to. We can chat about this more in detail tomorrow. I will be online in the afternoon.

@moog16 moog16 changed the base branch from fix/coverage-typescript to feat/two-typescript December 20, 2018 00:53
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@moog16 moog16 merged commit df62990 into feat/two-typescript Dec 21, 2018
@moog16 moog16 deleted the feat/typescript-button branch December 21, 2018 21:31
moog16 pushed a commit that referenced this pull request Dec 27, 2018
moog16 pushed a commit that referenced this pull request Dec 28, 2018
moog16 pushed a commit that referenced this pull request Dec 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants