New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ripple): Adds HTMLElement shim to fix regression for SSR projects #592
fix(ripple): Adds HTMLElement shim to fix regression for SSR projects #592
Conversation
Codecov Report
@@ Coverage Diff @@
## rc0.9.0 #592 +/- ##
===========================================
- Coverage 94.49% 94.45% -0.04%
===========================================
Files 61 61
Lines 2560 2561 +1
Branches 371 372 +1
===========================================
Hits 2419 2419
Misses 50 50
- Partials 91 92 +1
Continue to review full report at Codecov.
|
This looks like it fixed it, but I left one comment. I tested by using the repo linked in this issue #492. I actually found another similar issue using Drawer while testing.
I will open a separate issue. |
@4cm4k1 could you please sign the pr |
tests passing: #595 |
I signed it. |
Thanks! merging :) |
This PR fixes #581.
I did not write any tests, as writing tests for SSR use cases is under consideration at #588.
The compiled result of the changed code is as follows, which should fix the regression seen in SSR projects:
I’m relatively new to writing TypeScript, so please let me know if
any
as a type should be changed.Warm regards,
Anthony