[Incomplete] Feature: Snackbar implementation #620

gugu · 2019-01-16T21:13:40Z

The initial version of Snackbar. If code will be in general OK, I'll add tests as well

If you want to try: npm install @shortcm/snackbar

codecov-io · 2019-01-16T21:17:40Z

Codecov Report

Merging #620 into rc0.10.0 will increase coverage by 0.04%.
The diff coverage is 96.82%.

@@             Coverage Diff              @@
##           rc0.10.0     #620      +/-   ##
============================================
+ Coverage     94.83%   94.87%   +0.04%     
============================================
  Files            67       68       +1     
  Lines          2768     2831      +63     
  Branches        414      426      +12     
============================================
+ Hits           2625     2686      +61     
  Misses           50       50              
- Partials         93       95       +2

Impacted Files	Coverage Δ
packages/snackbar/index.tsx	`96.82% <96.82%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae38323...9d44be8. Read the comment docs.

moog16

Initial thoughts: code looks good, but things are missing.

foundation.close()
handleKeyDown()
getTimeoutMs()
getCloseOnEscape()
isOpen() // can be used through props.

packages/snackbar/index.tsx

packages/snackbar/package.json

packages/snackbar/index.tsx

moog16

Good initial set of tests, but need more coverage. We're aiming for 95% lines/functions/statements/branches. I know we are lacking in some areas, which we need to address. But we don't want to fall further behind. Added some comments.

packages/snackbar/README.md

packages/snackbar/index.tsx

packages/snackbar/package.json

packages/snackbar/types.tsx

scripts/package-json-reader.js

test/screenshot/snackbar/index.scss

test/unit/snackbar/index.test.tsx

moog16 · 2019-01-23T17:29:13Z

fixes #447

test/screenshot/snackbar/index.scss

packages/snackbar/index.tsx

moog16

I think the last piece is adding adapter tests to achieve 95% test coverage.

moog16 · 2019-01-24T17:12:15Z

@gugu I see you did more tests! If you run npm run test:unit, this will create a coverage directory. Can you make sure that branches, statements, lines, and functions is +95%. If you can't do it let me know. From the looks of it you're around:

86.96% Statements 60/69 75% Branches 18/24 65% Functions 13/20 85.48% Lines 53/62

You can also see line/by/line coverage. If you have any trouble, let me know and we can work through it.

googlebot · 2019-01-24T21:16:49Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

gugu · 2019-01-24T21:24:49Z

Done. It now says about CLA signing, probably after merge

moog16 · 2019-01-24T21:27:43Z

looks like you have some conflicting files. Also I only see a commit that updated karma. Did you forget some files in your last commit?

googlebot · 2019-01-25T11:18:43Z

CLAs look good, thanks!

gugu · 2019-01-25T11:23:57Z

The problem was when the base branch was changed. I removed extra commits and squashed my changes to one commit (to not to pollute module history). Also I added karma config instead of tests. Now test coverage is 100%

packages/snackbar/README.md

moog16 · 2019-01-25T17:57:49Z

I realized that you also need to add snackbar to the screenshot-test-urls.tsx file, and water with rc0.10.0.

gugu · 2019-01-25T18:51:12Z

Done with docs and screenshot-test-urls. What does "water with rc0.10.0." mean? I did rebase from rc0.10.0, but I'm not sure it is what did you mean

moog16 · 2019-01-25T18:52:26Z

water === merge...the more and more I say that, the more I think it is not a real term. Rebase is fine :)

packages/snackbar/README.md

moog16 · 2019-01-25T19:00:25Z

@gugu created a screenshot. please update snackbar golden.json file:
fb7f6f61f37095d7e7c92c9305eb797145d8e72c0c8dbc4e531f9aca91b0fd28

moog16 · 2019-01-25T21:08:24Z

i made the gc bucket public (I think)...try running npm run lint.

moog16 · 2019-01-25T21:57:49Z

tests for #637

moog16 · 2019-01-25T21:58:33Z

@gugu did you sign PR...i remember you doing so.

gugu · 2019-01-25T22:28:44Z

I signed it

gugu · 2019-01-25T22:29:06Z

Looks like this message I need to write to sign

moog16 · 2019-01-25T22:32:01Z

Thanks :)

Fix default classes WIP correct implementation of announce method Change modile name, onAnnounce event, handling keydown Add missing methods, unit tests Minimal screenshot tests Leading/stacked tests React-snackbar example ESLint Improve quality of react-snackbar (quick fixes) Add comments for snackbar test css hack, standard callback names in props Add TODO for updating types from mdc-snackbar when possible Added docs for announce, version 0.0.0, typescript lint fixes Adapter tests, moved mdc-snackbar to classes attribute Achieve 100% test coverage Revert karma changes Getting snackbar parameters docs

gugu · 2019-01-29T18:30:48Z

rebased to the last rc0.10.0 commit

moog16 suggested changes Jan 18, 2019

View reviewed changes

packages/snackbar/index.tsx Outdated Show resolved Hide resolved

packages/snackbar/package.json Outdated Show resolved Hide resolved

moog16 reviewed Jan 18, 2019

View reviewed changes

packages/snackbar/index.tsx Outdated Show resolved Hide resolved

moog16 suggested changes Jan 22, 2019

View reviewed changes

beaumartinez mentioned this pull request Jan 23, 2019

Add Snackbar component #447

Closed

moog16 reviewed Jan 23, 2019

View reviewed changes

test/screenshot/snackbar/index.scss Show resolved Hide resolved

moog16 reviewed Jan 23, 2019

View reviewed changes

packages/snackbar/index.tsx Outdated Show resolved Hide resolved

moog16 suggested changes Jan 23, 2019

View reviewed changes

moog16 changed the base branch from rc0.9.0 to rc0.10.0 January 24, 2019 17:13

gugu force-pushed the react-snackbar branch 2 times, most recently from 3358695 to 7365f13 Compare January 25, 2019 11:18

gugu force-pushed the react-snackbar branch 2 times, most recently from fc6a2c0 to 002ddca Compare January 25, 2019 11:22

moog16 reviewed Jan 25, 2019

View reviewed changes

packages/snackbar/README.md Show resolved Hide resolved

gugu force-pushed the react-snackbar branch from 002ddca to ce7e5cd Compare January 25, 2019 18:49

moog16 reviewed Jan 25, 2019

View reviewed changes

packages/snackbar/README.md Show resolved Hide resolved

gugu force-pushed the react-snackbar branch from ce7e5cd to 00ac6b4 Compare January 25, 2019 20:30

moog16 mentioned this pull request Jan 25, 2019

DO NOT MERGE Tests Snackbar implementation #637

Closed

gugu force-pushed the react-snackbar branch from 00ac6b4 to 9fe7bc7 Compare January 26, 2019 11:36

moog16 mentioned this pull request Jan 28, 2019

DO NOT MERGE Test Gugu react snackbar1 #642

Closed

gugu force-pushed the react-snackbar branch from 9fe7bc7 to 9d44be8 Compare January 29, 2019 18:08

moog16 approved these changes Jan 29, 2019

View reviewed changes

moog16 merged commit a2a4473 into material-components:rc0.10.0 Jan 29, 2019

moog16 pushed a commit that referenced this pull request Jan 30, 2019

feat(snackbar): new component (#620)

c33c2dd

moog16 pushed a commit that referenced this pull request Feb 19, 2019

feat(snackbar): new component (#620)

63e1fce

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Incomplete] Feature: Snackbar implementation #620

[Incomplete] Feature: Snackbar implementation #620

gugu commented Jan 16, 2019 •

edited

codecov-io commented Jan 16, 2019 •

edited

moog16 left a comment

moog16 left a comment

moog16 commented Jan 23, 2019

moog16 left a comment

moog16 commented Jan 24, 2019 •

edited

googlebot commented Jan 24, 2019

gugu commented Jan 24, 2019

moog16 commented Jan 24, 2019

googlebot commented Jan 25, 2019

gugu commented Jan 25, 2019

moog16 commented Jan 25, 2019

gugu commented Jan 25, 2019

moog16 commented Jan 25, 2019

moog16 commented Jan 25, 2019

moog16 commented Jan 25, 2019

moog16 commented Jan 25, 2019

moog16 commented Jan 25, 2019

gugu commented Jan 25, 2019

gugu commented Jan 25, 2019

moog16 commented Jan 25, 2019

gugu commented Jan 29, 2019

[Incomplete] Feature: Snackbar implementation #620

[Incomplete] Feature: Snackbar implementation #620

Conversation

gugu commented Jan 16, 2019 • edited

codecov-io commented Jan 16, 2019 • edited

Codecov Report

moog16 left a comment

Choose a reason for hiding this comment

moog16 left a comment

Choose a reason for hiding this comment

moog16 commented Jan 23, 2019

moog16 left a comment

Choose a reason for hiding this comment

moog16 commented Jan 24, 2019 • edited

googlebot commented Jan 24, 2019

gugu commented Jan 24, 2019

moog16 commented Jan 24, 2019

googlebot commented Jan 25, 2019

gugu commented Jan 25, 2019

moog16 commented Jan 25, 2019

gugu commented Jan 25, 2019

moog16 commented Jan 25, 2019

moog16 commented Jan 25, 2019

moog16 commented Jan 25, 2019

moog16 commented Jan 25, 2019

moog16 commented Jan 25, 2019

gugu commented Jan 25, 2019

gugu commented Jan 25, 2019

moog16 commented Jan 25, 2019

gugu commented Jan 29, 2019

gugu commented Jan 16, 2019 •

edited

codecov-io commented Jan 16, 2019 •

edited

moog16 commented Jan 24, 2019 •

edited