DO NOT MERGE Tests Snackbar implementation #637
Conversation
Fix default classes WIP correct implementation of announce method Change modile name, onAnnounce event, handling keydown Add missing methods, unit tests Minimal screenshot tests Leading/stacked tests React-snackbar example ESLint Improve quality of react-snackbar (quick fixes) Add comments for snackbar test css hack, standard callback names in props Add TODO for updating types from mdc-snackbar when possible Added docs for announce, version 0.0.0, typescript lint fixes Adapter tests, moved mdc-snackbar to classes attribute Achieve 100% test coverage Revert karma changes Getting snackbar parameters docs
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
Codecov Report
@@ Coverage Diff @@
## rc0.10.0 #637 +/- ##
============================================
+ Coverage 94.83% 94.87% +0.04%
============================================
Files 67 68 +1
Lines 2768 2831 +63
Branches 414 426 +12
============================================
+ Hits 2625 2686 +61
Misses 50 50
- Partials 93 95 +2
Continue to review full report at Codecov.
|
Tests for #620