fix(chips): implements missing adapter method notifyTrailingIconInteraction

[mgr34]

Implements missing adapter method notifyTrailingIconInteraction. Along with introducing shouldRemoveOnTrailingIconClick as ChipProp. (mdc-web may consider renaming this to shouldRemoveOnTrailingIconInteraction?)

A successful merge would close #652 and #271. Additionally would cause a breaking change where removeIcon is renamed to trailingIcon.

Screenshot tests were updated, however, golden.json may need attention.

---

I signed it

[codecov-io]

Codecov Report

Merging #653 into rc0.10.0 will increase coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           rc0.10.0    #653      +/-   ##
===========================================
+ Coverage     94.89%   94.9%   +0.01%     
===========================================
  Files            68      68              
  Lines          2838    2847       +9     
  Branches        426     428       +2     
===========================================
+ Hits           2693    2702       +9     
  Misses           50      50              
  Partials         95      95

Impacted Files	Coverage Δ
packages/chips/Chip.tsx	97.97% <100%> (+0.2%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9841e18...c7a842a. Read the comment docs.

[moog16]

This is awesome! Thanks so much for fixing this. There are a lot of missing pieces to chips so I'm really excited you put so much work into this.

please update the golden to:

f5973cc5f1961464cbbbe152ca25b9a989e7e5a54b6d64cb28f0c25788f7df44

[moog16]

@mgr34 looks like you have a conflict with readme.md

[mgr34]

@moog16 -- not just that it also looks like I accidentally committed my desire to update all dates to 2019...ugh. I thought I stashed all that.

Hold on, this needs some work.

[mgr34]

@moog16 -- merge resolve and commit reverted. Thought I had stashed my attempt to update everything to 2019.

[moog16]

looks good!

[moog16]

This is a breaking change...I will ammend the commit history. removeIcon --> trailingIcon

[mgr34]

to be clear I meant for this to be a breaking change and that removeIcon should now be trailingIcon. Semantically this is the logical choice.

[moog16]

yup that was my fault, thank you!