fix(list): renders a list with children which is not DOM #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
related to #663 |
|
I signed it! |
Codecov Report
@@ Coverage Diff @@
## rc0.10.0 #674 +/- ##
============================================
+ Coverage 94.81% 94.88% +0.07%
============================================
Files 68 68
Lines 2852 2852
Branches 431 432 +1
============================================
+ Hits 2704 2706 +2
+ Misses 51 50 -1
+ Partials 97 96 -1
Continue to review full report at Codecov.
|
moog16
suggested changes
Feb 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now
<List />checks children's type usingisListItem.If parameter is null/undefined, an error occurs.
So I add code that checks element's existence.
p.s. I add one dependency(@material/radio) because there is error "cannot find module" when running test code. If you do not need it, I will revert it.