Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(list): add ripple to list-item #894

Merged
merged 4 commits into from May 29, 2019
Merged

feat(list): add ripple to list-item #894

merged 4 commits into from May 29, 2019

Conversation

ghost
Copy link

@ghost ghost commented May 27, 2019

resolves #385

There are two lines that uses any type 😢
If you have suggestion, tell me about that.

@codecov-io
Copy link

codecov-io commented May 27, 2019

Codecov Report

Merging #894 into rc0.13.0 will increase coverage by 0.52%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           rc0.13.0     #894      +/-   ##
============================================
+ Coverage     93.99%   94.51%   +0.52%     
============================================
  Files            85       85              
  Lines          3578     3500      -78     
  Branches        561      533      -28     
============================================
- Hits           3363     3308      -55     
+ Misses           90       66      -24     
- Partials        125      126       +1
Impacted Files Coverage Δ
packages/list/ListItem.tsx 98.95% <100%> (-0.03%) ⬇️
packages/list/ListDivider.tsx 83.33% <0%> (-5.56%) ⬇️
packages/card/ActionIcons.tsx 92.85% <0%> (-0.9%) ⬇️
packages/card/ActionButtons.tsx 92.85% <0%> (-0.9%) ⬇️
packages/menu-surface/index.tsx 85.18% <0%> (-0.36%) ⬇️
packages/menu/index.tsx 90% <0%> (-0.25%) ⬇️
packages/select/EnhancedSelect.tsx 93.82% <0%> (-0.23%) ⬇️
packages/select/BaseSelect.tsx 90% <0%> (-0.17%) ⬇️
packages/dialog/index.tsx 97.9% <0%> (-0.14%) ⬇️
packages/ripple/index.tsx 85.83% <0%> (-0.12%) ⬇️
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c41d809...ecde77d. Read the comment docs.

@ghost
Copy link
Author

ghost commented May 28, 2019

OMG I didn't change target branch to rc0.13.0
Please change base branch 😅

@moog16 moog16 changed the base branch from master to rc0.13.0 May 28, 2019 16:37
packages/list/ListItem.tsx Outdated Show resolved Hide resolved
Copy link

@moog16 moog16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Please update the

@moog16 moog16 merged commit af1b20b into material-components:rc0.13.0 May 29, 2019
@moog16 moog16 mentioned this pull request May 29, 2019
moog16 pushed a commit that referenced this pull request May 30, 2019
@ghost ghost deleted the ripple-list-item branch June 1, 2019 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants