-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(text-field): add placeholder property #930
feat(text-field): add placeholder property #930
Conversation
Codecov Report
@@ Coverage Diff @@
## rc0.14.0 #930 +/- ##
============================================
+ Coverage 94.08% 94.09% +<.01%
============================================
Files 86 86
Lines 3637 3640 +3
Branches 573 575 +2
============================================
+ Hits 3422 3425 +3
Misses 90 90
Partials 125 125
Continue to review full report at Codecov.
|
Can you change the branch to rc0.14.0 |
ba1a08f
to
26e7859
Compare
26e7859
to
0a69c32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please ping me when this is ready for rereview. |
@moog16 This is an issue in MDC Web that has been fixed in v2.1.0 |
@moog16 Updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve conflicts. Looks good!
1247795
to
839b6fe
Compare
@moog16 Rebased onto rc0.14.0 |
Can you add to the
|
The golden for fullWidth needs updated as well, since it has no label and gets the same mdc-text-field-no-label class that had the padding change in MDC Web 2.1.0 |
related to #224
Reopening of #840, since that was targeting an old feature branch.