Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(line-ripple): Convert style name to camel case #99

Merged
merged 2 commits into from Jun 20, 2018
Merged

fix(line-ripple): Convert style name to camel case #99

merged 2 commits into from Jun 20, 2018

Conversation

lucasecdb
Copy link
Contributor

@lucasecdb lucasecdb commented Jun 10, 2018

fixes #86

@codecov-io
Copy link

codecov-io commented Jun 10, 2018

Codecov Report

Merging #99 into master will increase coverage by 0.15%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
+ Coverage   99.05%   99.21%   +0.15%     
==========================================
  Files          18       18              
  Lines         636      633       -3     
  Branches       53       51       -2     
==========================================
- Hits          630      628       -2     
+ Misses          6        5       -1
Impacted Files Coverage Δ
packages/line-ripple/index.js 100% <100%> (ø) ⬆️
packages/text-field/Input.js 100% <0%> (+1.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1d8b66...2bd7077. Read the comment docs.

@moog16
Copy link
Contributor

moog16 commented Jun 15, 2018

@lucasecdb didn't see this! I also fixed it with a simple if statement. See #102.

Could you add a test? Similar to the one in my PR?

@lucasecdb
Copy link
Contributor Author

@moog16 sure!

@moog16
Copy link
Contributor

moog16 commented Jun 19, 2018

Cool thanks for making that change. I will open another PR so it runs the tests.

#106

@moog16
Copy link
Contributor

moog16 commented Jun 19, 2018

@lucasecdb can you please sign this PR

@moog16
Copy link
Contributor

moog16 commented Jun 19, 2018

Hmm interesting, tests are passing in this PR now. But #106 also is passing. Once you sign this one, we can merge it!

@lucasecdb
Copy link
Contributor Author

@googlebot I give my consent!

Copy link
Contributor

@moog16 moog16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are passing in #106

@moog16 moog16 merged commit 2a5341c into material-components:master Jun 20, 2018
@lucasecdb lucasecdb deleted the fix/line-ripple/transform-origin-warning branch June 20, 2018 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants