-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(line-ripple): Convert style name to camel case #99
fix(line-ripple): Convert style name to camel case #99
Conversation
Codecov Report
@@ Coverage Diff @@
## master #99 +/- ##
==========================================
+ Coverage 99.05% 99.21% +0.15%
==========================================
Files 18 18
Lines 636 633 -3
Branches 53 51 -2
==========================================
- Hits 630 628 -2
+ Misses 6 5 -1
Continue to review full report at Codecov.
|
@lucasecdb didn't see this! I also fixed it with a simple Could you add a test? Similar to the one in my PR? |
@moog16 sure! |
Cool thanks for making that change. I will open another PR so it runs the tests. |
@lucasecdb can you please sign this PR |
Hmm interesting, tests are passing in this PR now. But #106 also is passing. Once you sign this one, we can merge it! |
@googlebot I give my consent! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests are passing in #106
fixes #86