Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(top-app-bar): TopAppBarFixedAdjust variants added #524

Conversation

mgr34
Copy link
Contributor

@mgr34 mgr34 commented Dec 14, 2018

This references #518 and can be closed with the previous merging of PR #520.

I am still unsure about screenshot testing. running yarn capture did update the correct part's of golden.json and everything appears as expected from yarn start.


I signed it

@codecov-io
Copy link

codecov-io commented Dec 14, 2018

Codecov Report

Merging #524 into rc0.8.0 will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           rc0.8.0     #524      +/-   ##
===========================================
+ Coverage    96.62%   96.63%   +0.01%     
===========================================
  Files           59       59              
  Lines         1984     1991       +7     
  Branches       235      239       +4     
===========================================
+ Hits          1917     1924       +7     
  Misses          67       67
Impacted Files Coverage Δ
packages/top-app-bar/index.js 100% <ø> (ø) ⬆️
packages/top-app-bar/FixedAdjust.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a4e941...55047c4. Read the comment docs.

Copy link
Contributor

@moog16 moog16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening PR! Just a few changes.

packages/top-app-bar/FixedAdjust.js Outdated Show resolved Hide resolved
packages/top-app-bar/README.md Show resolved Hide resolved
packages/top-app-bar/README.md Outdated Show resolved Hide resolved
test/screenshot/golden.json Outdated Show resolved Hide resolved
@moog16
Copy link
Contributor

moog16 commented Dec 17, 2018

tests: #538

@moog16
Copy link
Contributor

moog16 commented Dec 17, 2018

Test passing and CLA signed in: #524 (comment) merging!

@moog16 moog16 merged commit 160cf3a into material-components:rc0.8.0 Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants