Fix z-index & wrong CSS #1094
Fix z-index & wrong CSS #1094
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1094 +/- ##
======================================
Coverage 99.9% 99.9%
======================================
Files 69 69
Lines 3305 3305
Branches 405 405
======================================
Hits 3302 3302
Misses 3 3Continue to review full report at Codecov.
|
| @@ -116,7 +116,7 @@ They only need to match the values set for their corresponding aria attributes. | |||
|
|
|||
| Dialog actions use system colors by default, but you can use a contrasting color, such as the palette’s accent color, to distinguish dialog actions from dialog content. To emphasize an action from other contents, add `mdc-dialog__action` to `mdc-button` to apply accent color. | |||
|
|
|||
| ``` | |||
| ```html | |||
| <aside class="mdc-dialog"> | |||
| <div class="mdc-dialog__surface"> | |||
There was a problem hiding this comment.
Needs closing </div> in example
There was a problem hiding this comment.
Thanks. Just fixed it.
|
Testing in Angular MDC..LGTM. Thanks for the fix! |
|
No problem, happy to be a part of the community! |
|
@lynnjepsen Should this be merged 😃? |
|
I'd still like an example of a dialog with an action button added to our demo page. Then we can merge it. |
|
@lynnjepsen Sorry, I thought I added the demo but it turns out I didn't. Just added it 😃 |
|
No problem :) |
Fixes and closes #1095 #1096