Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(dialog): Wrong CSS with 'mdc-dialog__action' #1096

Closed
touficbatache opened this issue Aug 8, 2017 · 1 comment
Closed

(dialog): Wrong CSS with 'mdc-dialog__action' #1096

touficbatache opened this issue Aug 8, 2017 · 1 comment
Assignees
@lynnmercier
Labels
bug

Comments

@touficbatache
Copy link
Contributor

Bugs

What MDC-Web Version are you using?

0.17.0

What browser(s) is this bug affecting?

All browsers

What OS are you using?

All OS

What are the steps to reproduce the bug?

  1. Go to http://material-components-web.appspot.com/dialog.html
  2. Add the mdc-dialog__action class to any button
  3. Observe the component's behavior

What is the expected behavior?

The button should be accent colored

What is the actual behavior?

Nothing happens

Any other information you believe would be useful?

This is because of wrong CSS, my last PR fixes it
@touficbatache touficbatache mentioned this issue Aug 8, 2017
Merged
@acdvorak
Copy link
Contributor

Nice catch, thanks @touficbatache!

@acdvorak acdvorak added the bug label Aug 11, 2017
lynnmercier pushed a commit that referenced this issue Aug 28, 2017
@touficbatache @lynnmercier
fix(dialog): Fix z-index & wrong CSS (#1094)
88b7167 
Resolves #1095 #1096
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lynnmercier lynnmercier

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@acdvorak @lynnmercier @touficbatache