refactor(demos): Split out and remove demos.scss #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives each demo (or set of demos, in some cases) its own separate scss file, allowing us to more clearly add demo-specific Sass to illustrate use of the theme mixins we've started developing. It should also open up more potential to speed up our compilation process.
Codecov Report
@@ Coverage Diff @@
## master #1285 +/- ##
======================================
Coverage 99.9% 99.9%
======================================
Files 69 69
Lines 3314 3314
Branches 409 409
======================================
Hits 3311 3311
Misses 3 3Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives each demo (or set of demos, in some cases) its own separate scss
file, allowing us to more clearly add demo-specific Sass to illustrate use of
the theme mixins we've started developing. It should also open up more
potential to speed up our compilation process.
This PR does not go about moving all demo-specific styles from the HTML files into the SCSS files; I figured that'd make the diff ridiculously large, so we can tackle that separately if/when we want to do it.