fix(ripple): Move feature detect CSS to mixins #1302
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the feature detect CSS to be automatically included by other components
that rely on ripple mixins (e.g. button). This problem was evidenced after I split demos.scss in #1285 which caused regressions in Edge due to the feature-detect CSS no longer being loaded in other pages such as button.html. Thanks @yeelan0319 for catching this!
It may seem odd for a mixins file to emit styles, but ripple's mixins file already does so because it imports
./keyframes
(which contributes to #1295). In both cases (keyframes and the feature-detect styles), this is done so that other components which are designed to support or instantiate ripples (e.g. button, dialog, etc.) function correctly without needing to separately explicitly includemdc-ripple.scss
.