Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(text-field): Changes to text area label positioning to cover text content #2816

Merged
merged 9 commits into from
May 30, 2018
Merged

fix(text-field): Changes to text area label positioning to cover text content #2816

Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
054cc5e
fix(rtl): Make mdc-rtl-reflexive sass mixin public.
abhiomkar May 25, 2018
4458c28
fix(text-field): Changes to text area label positioning to cover text…
abhiomkar May 25, 2018
76db830
feat(rtl): Make mdc-rtl-reflexive sass mixin public.
abhiomkar May 25, 2018
c755fa3
Merge remote-tracking branch 'origin/master' into fix_rtl_reflexive_p…
abhiomkar May 25, 2018
8f79221
Merge branch 'fix_rtl_reflexive_public_issue2392' into fix_textfield_…
abhiomkar May 25, 2018
bf145c8
fix(text-field): Resolved conflict and merged with origin/master
abhiomkar May 29, 2018
cb46655
Merge remote-tracking branch 'origin/master' into fix_textfield_texta…
abhiomkar May 30, 2018
eb3d849
feat(fab): Removed trailing whitespace
abhiomkar May 30, 2018
20acb41
Merge branch 'master' into fix_textfield_textarea_label_fullwidth_iss…
abhiomkar May 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions packages/mdc-textfield/_mixins.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,15 +494,16 @@
}

.mdc-floating-label {
@include mdc-rtl-reflexive-position(left, 1px);
@include mdc-floating-label-fill-color($mdc-textarea-background);

@include mdc-rtl-reflexive(left, 1px, right, 0);
@include mdc-rtl-reflexive-property(margin, 8px, 0);

Copy link
Contributor

@kfranqueiro kfranqueiro May 30, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint is failing due to the indentation on this empty line

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

top: $label-offset-y;
bottom: auto;
margin-top: 2px;
margin-left: 8px;
padding: 8px;
padding: 12px 8px 8px 8px;
line-height: 1.15;
pointer-events: none;
}
}

Expand Down