-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(drawer): Use parentNode DOM API when selecting scrim to make it work with Shadow DOM #4265
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4265 +/- ##
=======================================
Coverage 98.48% 98.48%
=======================================
Files 130 130
Lines 5736 5736
Branches 766 766
=======================================
Hits 5649 5649
Misses 87 87
Continue to review full report at Codecov.
|
All 758 screenshot tests passed for commit ccd2353 vs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we just need a unit test for this, and then it should be good to go!
@acdvorak Updated unit test to include test for shadow dom. PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified that the unit test fails with parentElement
and passes with parentNode
.
LGTM! Thanks Abhinay!
All 621 screenshot tests passed for commit cefa3b3 vs. |
Fixes #4254