Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(drawer): Use parentNode DOM API when selecting scrim to make it work with Shadow DOM #4265

Merged
merged 5 commits into from
Jan 31, 2019

Conversation

abhiomkar
Copy link
Collaborator

Fixes #4254

@codecov-io
Copy link

codecov-io commented Jan 18, 2019

Codecov Report

Merging #4265 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4265   +/-   ##
=======================================
  Coverage   98.48%   98.48%           
=======================================
  Files         130      130           
  Lines        5736     5736           
  Branches      766      766           
=======================================
  Hits         5649     5649           
  Misses         87       87
Impacted Files Coverage Δ
packages/mdc-drawer/index.js 97.22% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dffbcc1...cefa3b3. Read the comment docs.

@mdc-web-bot
Copy link
Collaborator

All 758 screenshot tests passed for commit ccd2353 vs. master! 💯🎉

Copy link
Contributor

@acdvorak acdvorak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we just need a unit test for this, and then it should be good to go!

@acdvorak acdvorak self-assigned this Jan 25, 2019
@abhiomkar
Copy link
Collaborator Author

@acdvorak Updated unit test to include test for shadow dom. PTAL.

Copy link
Contributor

@acdvorak acdvorak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified that the unit test fails with parentElement and passes with parentNode.

LGTM! Thanks Abhinay!

@mdc-web-bot
Copy link
Collaborator

All 621 screenshot tests passed for commit cefa3b3 vs. master! 💯🎉

@abhiomkar abhiomkar merged commit 385a223 into master Jan 31, 2019
@abhiomkar abhiomkar deleted the fix/drawer_parentnode branch January 31, 2019 23:22
@jamesmfriedman jamesmfriedman mentioned this pull request Feb 5, 2019
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants