feat(mdc-list): introduce selection change event #7443
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a new custom event called `MDCList:selectionChange` that fires whenever the selection of the list has changed through user interaction. This matches with the semantics of the native `change` event of input controls. This event is useful as not every type of list has an underlying native control, like in the checkbox-type list, where the `change` event from the control may bubble up. Even for those cases though the native event is not guaranteed to fire in all cases. e.g. it does not fire when a user leverages the `CTRL + A` keybinding we support in the list foundation. This commit adds a new type of event/notification that can be leveraged in the foundation through an adapter method (needed by Angular), or consumers could use it through `MDCList:selectionChange`.
There was a problem hiding this comment.
Lots of nice improvements to names and code organization. Thanks for all the effort that went into this PR!
Added a general comment about circumstances in which the underlying control would have received a click event -- I may be misunderstanding the comment, but the intention is for these controls not to be tappable/clickable (via pointer-events: none).
Use consistent quotes and spacing
devversion
added a commit
to devversion/material2
that referenced
this pull request
Dec 9, 2021
…Click signature change Accounts for the mdc-list handleClick signature/semantics change as with: material-components/material-components-web#7443.
devversion
added a commit
to devversion/material2
that referenced
this pull request
Dec 9, 2021
…Click signature change Accounts for the mdc-list handleClick signature/semantics change as with: material-components/material-components-web#7443.
devversion
added a commit
to devversion/material2
that referenced
this pull request
Dec 9, 2021
…Click signature change Accounts for the mdc-list handleClick signature/semantics change as with: material-components/material-components-web#7443.
devversion
added a commit
to devversion/material2
that referenced
this pull request
Dec 9, 2021
…Click signature change Accounts for the mdc-list handleClick signature/semantics change as with: material-components/material-components-web#7443.
devversion
added a commit
to devversion/material2
that referenced
this pull request
Dec 10, 2021
…Click signature change Accounts for the mdc-list handleClick signature/semantics change as with: material-components/material-components-web#7443.
andrewseguin
pushed a commit
to angular/components
that referenced
this pull request
Dec 10, 2021
…Click signature change (#24076) Accounts for the mdc-list handleClick signature/semantics change as with: material-components/material-components-web#7443. (cherry picked from commit 97ec228)
andrewseguin
pushed a commit
to angular/components
that referenced
this pull request
Dec 10, 2021
…Click signature change (#24076) Accounts for the mdc-list handleClick signature/semantics change as with: material-components/material-components-web#7443.
|
merged with 7d8ea46 |
forsti0506
pushed a commit
to forsti0506/components
that referenced
this pull request
Apr 3, 2022
…Click signature change (angular#24076) Accounts for the mdc-list handleClick signature/semantics change as with: material-components/material-components-web#7443.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new custom event called
MDCList:selectionChangethatfires whenever the selection of the list has changed through user
interaction. This matches with the semantics of the native
changeevent of input controls.
This event is useful as not every type of list has an underlying
native control, like in the checkbox-type list, where the
changeevent from the control may bubble up. Even for those cases though
the native event is not guaranteed to fire in all cases. e.g. it
does not fire when a user leverages the
CTRL + Akeybinding wesupport in the list foundation.
This commit adds a new type of event/notification that can be
leveraged in the foundation through an adapter method (needed by
Angular), or consumers could use it through
MDCList:selectionChange.Note that the custom action event being emitted here is not semantically
equivalent as this one fires regardless of whether the selection has actually changed
or not. This seems like another use-cases, as seen in the MDC menu.
Note: also fixes that the unit tests did not run properly as there was a
fitleftover pushed tomaster. This commit fixes that and sets up a lint to prevent this in the future.