Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image size on cards #21

Merged
merged 12 commits into from
Apr 6, 2021
Merged

Image size on cards #21

merged 12 commits into from
Apr 6, 2021

Conversation

ravichdev
Copy link
Contributor

@ravichdev ravichdev commented Apr 1, 2021

Summary

Fixes #17

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Contributing Guidelines (updates are often made to the guidelines, check it out periodically).

@ravichdev ravichdev changed the title Can't remove image from card Image size on cards Apr 1, 2021
@ravichdev ravichdev requested a review from emeaguiar April 1, 2021 18:30
@coveralls
Copy link

coveralls commented Apr 2, 2021

Pull Request Test Coverage Report for Build 711389945

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 85.252%

Totals Coverage Status
Change from base Build 687484382: 0.07%
Covered Lines: 3881
Relevant Lines: 4437

💛 - Coveralls

emeaguiar
emeaguiar previously approved these changes Apr 2, 2021
Copy link
Collaborator

@emeaguiar emeaguiar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@emeaguiar emeaguiar merged commit 601b06b into develop Apr 6, 2021
@emeaguiar emeaguiar deleted the feature/566-card-image branch April 6, 2021 04:39
ravichdev pushed a commit that referenced this pull request Apr 13, 2021
rodydavis pushed a commit that referenced this pull request Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image size on homepage
3 participants