Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M3 Button #417

Merged
merged 31 commits into from
Aug 23, 2022
Merged

M3 Button #417

merged 31 commits into from
Aug 23, 2022

Conversation

emeaguiar
Copy link
Collaborator

Summary

Fixes #325

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Contributing Guidelines (updates are often made to the guidelines, check it out periodically).

@PatelUtkarsh
Copy link
Collaborator

Hello @emeaguiar,
4790e10 should fix the migration. Can you check at your end?

@coveralls
Copy link

coveralls commented Aug 11, 2022

Pull Request Test Coverage Report for Build 2886956754

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 35 of 35 (100.0%) changed or added relevant lines in 17 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.9%) to 72.189%

Totals Coverage Status
Change from base Build 2886861237: 0.9%
Covered Lines: 4742
Relevant Lines: 6438

💛 - Coveralls

Copy link
Collaborator

@PatelUtkarsh PatelUtkarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PatelUtkarsh PatelUtkarsh merged commit 86f4005 into develop Aug 23, 2022
@PatelUtkarsh PatelUtkarsh deleted the m3/button branch August 23, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[M3] Components - Button
3 participants