Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Poetry Python icon #1155

Merged
merged 4 commits into from Mar 17, 2022
Merged

Add Poetry Python icon #1155

merged 4 commits into from Mar 17, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jul 8, 2021

More Python environment tooling. See https://github.com/python-poetry/poetry/blob/master/README.md for details.

@PKief PKief force-pushed the main branch 9 times, most recently from c149f3c to 6ed12b6 Compare January 23, 2022 19:28
PKief
PKief requested changes Mar 17, 2022
View reviewed changes
Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the icon but I was wondering if you could change the colors to be out of the Material Color palette.

@PKief PKief linked an issue Mar 17, 2022 that may be closed by this pull request
[Icon Request] Specific icon for poetry.lock #1397
Closed
2 tasks
@ghost
Copy link
Author

ghost commented Mar 17, 2022

Done

@PKief
Copy link
Member

PKief commented Mar 17, 2022

Done

Thank you, unfortunately I just noticed that the pipeline is still failing because of an invalid color code. Could you please take a look at it and check the color codes? 🙈

Failing pipeline:
https://github.com/PKief/vscode-material-icon-theme/runs/5589652094?check_suite_focus=true

@ghost
Copy link
Author

ghost commented Mar 17, 2022

Got it 😅 switched it from #00b8eb to #29B6F6 to keep luminance similar

PKief
PKief approved these changes Mar 17, 2022
View reviewed changes
Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I also think #29B6F6 was the best choice here ;)

@PKief PKief merged commit 8c92bc5 into material-extensions:main Mar 17, 2022
@PKief PKief mentioned this pull request Mar 17, 2022
Closed
2 tasks
@ghost ghost deleted the python-poetry branch March 17, 2022 22:19
PKief added a commit that referenced this pull request Mar 19, 2022
@bart-krakowski @binyamin
@PKief @bripkens @azat-io @ViktorOn
feat: turborepo (#1388)
61bf359 
* feat: figma

* fix: removed figma

* feat: turborepo

* Support partials folders (#1307)

* Support partials folders

For either sass includes or HTML templates (eg. nunjucks)

* Fix prettier issue

Co-authored-by: Philipp Kief <philipp.kief@gmx.de>

* Update vscodeignore

* Release 4.14.0

* Hardhat icon is broken (#1420)

Fixes #1419

* Release 4.14.1

* feat: fileicon for steadybit configuration files (#1399)

* feat: fileicon for steadybit configuration files

* Update steadybit.svg

Co-authored-by: Philipp Kief <philipp.kief@gmx.de>

* feat: support avif image file type (#1424)

* Update lang-ru.ts (#1427)

* Update lang-ru.ts (#1428)

* Add Poetry Python icon (#1155)

* Add Poetry Python icon

* Remove gradients from Poetry icon (#1155)

* Apply Material Design color to `poetry`

Co-authored-by: 4086606 <82655227+4086606@users.noreply.github.com>
Co-authored-by: Philipp Kief <philipp.kief@gmx.de>

* fix: changed colors and added the light variant

* Update position of icons

Co-authored-by: Binyamin Aron Green <binyaminagreen@gmail.com>
Co-authored-by: Philipp Kief <philipp.kief@gmx.de>
Co-authored-by: Philipp Kief <PKief@users.noreply.github.com>
Co-authored-by: Ben Blackmore <bripkens@gmail.com>
Co-authored-by: Azat S <to@azat.io>
Co-authored-by: Viktor <63919734+ViktorOn@users.noreply.github.com>
Co-authored-by: M.U.N.I.N <82655227+SNDST00M@users.noreply.github.com>
Co-authored-by: 4086606 <82655227+4086606@users.noreply.github.com>
@michaeloliverx
Copy link
Contributor

I think adding a poetry icon for pyproject.toml is incorrect, pyproject.toml was formalised in https://peps.python.org/pep-0518/ and is used by many tools to store their configuration. The poetry icon poetry.lock is okay as that file is solely for poetry.

@ghost
Copy link
Author

ghost commented Apr 1, 2022

Ideally then pyproject.toml should be associated with python-misc. You able to do that or should I try open a pull sometime?

PKief added a commit that referenced this pull request Apr 2, 2022
@PKief
Remove pyproject.toml from poetry icon (#1155)
6c35981
@PKief
Copy link
Member

PKief commented Apr 2, 2022

@sndst00m I created one #1459

PKief added a commit that referenced this pull request Apr 3, 2022
@PKief
Associate pyproject.toml with python-misc file icon (#1459)
968d3d5 
* Add pyproject.toml icon association

* Remove pyproject.toml from poetry icon (#1155)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Icon Request] Specific icon for poetry.lock
2 participants
@PKief @michaeloliverx