-
-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/update angular and nest icons #2314
Conversation
Merge SuccessfulThanks for your contribution! 🎉 The changes will be part of the upcoming update on the marketplace. |
Hello 👋 I have a question. Thank You |
@devuco you have to update your user settings like that: {
"material-icon-theme.activeIconPack": "nest",
} Or simply run the following command and select "Nest": |
Thank You |
It looks like my file associations to the cloned icons no longer show: "material-icon-theme.activeIconPack": "nest",
"material-icon-theme.files.associations": {
"*.type.ts": "nest-controller",
"*.utils.ts": "nest-decorator"
}, my |
@nowlena You're right. We allowed us to change the API with the last update to introduce a new clone API. That means that there's no nest-controller SVG icon existing anymore. Instead of that you have to clone the existing nest SVG icon and add some color to it like that: "material-icon-theme.files.customClones": [
{
"name": "nest-controller",
"base": "nest",
"color": "light-blue-700",
"fileExtensions": ["type.ts"]
},
{
"name": "nest-decorator",
"base": "nest",
"color": "purple-400",
"fileExtensions": ["utils.ts"]
}
] Then it should work as before: The advantages of that is, that you are not depending on any existing colors anymore but can choose any color that you want for your icons. Here you can find a list of the available colors of the Material Design palette: https://github.com/PKief/vscode-material-icon-theme/blob/main/src/icons/generator/clones/utils/color/materialPalette.ts You can find more information about the clone feature in our documentation: |
@PKief maybe we could find a way to make Oh, completely unrelated: I noticed the new svgo action removes the |
@lucas-labs Yeah that would be nice, because I think there might be other users as well where it might have broken some configurations. If you like you can analyze this. Ah okay, that's unfortunate that svgo removes the attribute. Good that you found that out! I just reverted the removal of the "mit-no-recolor" attribute so that these are still there. Yeah with some plugins it should work. We should figure this out, because svgo is a nice way to optimize the icons. |
@lucas-labs I think I've found a solution for the removal of our attribute: https://github.com/PKief/vscode-material-icon-theme/pull/2322 |
Making use of the new API for cloning existing icons to replicate them.
Preview looks like that (so remains the same, but based on a single SVG file):
Angular
![angular-file-changes](https://private-user-images.githubusercontent.com/12248527/328038661-0c790e8a-2da9-4e1e-a280-e46ce9632b68.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU2MjY5MTUsIm5iZiI6MTcyNTYyNjYxNSwicGF0aCI6Ii8xMjI0ODUyNy8zMjgwMzg2NjEtMGM3OTBlOGEtMmRhOS00ZTFlLWEyODAtZTQ2Y2U5NjMyYjY4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTA2VDEyNDMzNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWVkYWRjY2U2MDEwODFlOWIyMzhiNzFlY2Q5ZTExYTUzOTkxMTBkMWM3NzMzZmQ4ZDIxODM4OTE5ZDRmMzZiMjQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Ww5bVssSbcjzqw0YRUXHpvOSYhTIWNM0YwHGFROFK8s)
Nest
![nest-file-changes](https://private-user-images.githubusercontent.com/12248527/328038664-2f450737-60cd-4e0d-8819-05c00492f8be.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU2MjY5MTUsIm5iZiI6MTcyNTYyNjYxNSwicGF0aCI6Ii8xMjI0ODUyNy8zMjgwMzg2NjQtMmY0NTA3MzctNjBjZC00ZTBkLTg4MTktMDVjMDA0OTJmOGJlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTA2VDEyNDMzNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWE2YmZlNzUzYmY4NTM0ZmVmNTgzMzdjNjJmMzU1YjM0YTIyNmYxOTZjY2E5YzI3ZWNhOWNjYzY5N2E3Yzg4MzYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.r_CDje2kx7gyhlKp9h0GTj2zhksAJ9pY_TCo9ZuDdcs)