Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the detailsPanel prop while using components overriding breaks the component #282

Closed
josue-uitzil-by opened this issue Jul 29, 2021 · 6 comments
Labels
bug Something isn't working

Comments

@josue-uitzil-by
Copy link

josue-uitzil-by commented Jul 29, 2021

Hi, here is a codesandbox in which the issue can be reproduced: https://codesandbox.io/s/material-table-starter-template-forked-uvmpq?file=/src/index.js.

If you remove the detailsPanel prop (for example for hiding it) while it is open and you are using component overriding for the Row, the MaterialTable breaks and shows the following error:

Screen Shot 2021-07-29 at 15 17 25

The issue seems to have first appeared in release 3.1.0; if you change the version in codesandbox to 3.0.17 the component will work correctly.

To reproduce:

  1. On the codesandbox demo expand the details panel of any row
  2. Click on the button 'Toggle details panel visibility'
  3. The table will break

Screen Recording 2021-07-29 at 15 29 48

Expected behavior
The details panel should disappear without breaking the component.

Desktop:

  • OS: macOS Big Sur
  • Browser: Chrome
  • Version: 92.0.4515.107
@josue-uitzil-by josue-uitzil-by added the bug Something isn't working label Jul 29, 2021
@oze4
Copy link
Member

oze4 commented Jul 29, 2021

I believe this is known. Would you mind trying the latest release?

@josue-uitzil-by
Copy link
Author

Hi, thanks for your reply. I tested with the latest release (3.2.4) and also with 3.1.2 and in both versions the issue appears, only after downgrading to 3.0.17 the issue disappears.

@oze4
Copy link
Member

oze4 commented Jul 29, 2021

Interesting. I'll take a look here in a few. If you already know a fix, we would be happy to merge a PR.

Thanks again!

@oze4
Copy link
Member

oze4 commented Jul 29, 2021

This should be resolved in v3.2.5 - would you mind giving that version a try and letting us know the result?

Thank you!

@oze4
Copy link
Member

oze4 commented Jul 30, 2021

#285 please let me know if this is still an issue after upgrading! Thank you.

@oze4 oze4 closed this as completed Jul 30, 2021
@josue-uitzil-by
Copy link
Author

Hi, the issue is solved in the new release. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants