fix: edit mode with fixed columns breaks table layout #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So it was this easy huh? Cool 😄 Thanks! |
|
I just saw it. Looks like an easy fix 😜 thank you. I'll merge it Tonight and probably release tomorrow with the other PR that's in the works. |
Domino987
approved these changes
Mar 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
#480
Description
With fixedColumns set for the table, the Edit mode breaks the icon visibility at the row level.
The issue occurs due to the
overflowXproperty set tohiddenforfixedColumns.left. Modifying the value tovisibleresolves the issue.Impacted Areas in Application
Additional Notes
I have added a demo component for this particular fix. This could be added to the website if needed as well.