fix: background shadow breaks for fixed columns #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you show a before and after png pls? So I can verify? |
|
Sorry about that. Should have added it in the first place. When i modified the overflowX to Changing it to Please let me know if I need to provide any more info on this. :) |
|
No this looks perfect. I'll merge it today and release it subsequently. Thank you for this. |
Domino987
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
#480
Description
The overflowX property being updated to
visibledoes fix the leftIcons visibility issue, but the background shadows vanish for the fixed columns. Updating the value toclipresolves both the issues.Related PRs
List related PRs against other branches:
Impacted Areas in Application
List general components of the application that this PR will affect:
* MaterialTable