Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console warning #675

Merged
merged 1 commit into from
Nov 20, 2022
Merged

console warning #675

merged 1 commit into from
Nov 20, 2022

Conversation

dsheng123
Copy link
Contributor

'Property `sorting` has been deprecated, please start using `maxColumnSort` instead. https://github.com/material-table-core/core/pull/619'

Related Issue

#671

Description

A console.warn was triggered by a deprecated default prop in material-table.js

'Property `sorting` has been deprecated, please start using `maxColumnSort` instead. https://github.com/material-table-core/core/pull/619'

from

Impacted Areas in Application

fixes console.warn in dev mode

Additional Notes

This fix can be verified by looking at the output of the tests. For example summaryRow.test.js. The warning does not appear after this fix anymore

```
'Property `sorting` has been deprecated, please start using `maxColumnSort` instead. #619'
```
@dsheng123 dsheng123 requested a review from oze4 as a code owner November 18, 2022 15:07
@Domino987 Domino987 merged commit fbb1c65 into material-table-core:next Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants