fix(issue180): handling invalid clickedIndex in carousel.js #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RamonvdW
reviewed
Sep 18, 2021
RamonvdW
reviewed
Sep 18, 2021
DanielRuf
reviewed
Sep 18, 2021
DanielRuf
reviewed
Sep 18, 2021
|
Point of information. Using the parentheses makes it more obvious, but the modulo operator still has higher precedence so mathematically there is no difference.
… On Sep 18, 2021, at 9:13 AM, Daniel Wurzer ***@***.***> wrote:
@wuda-io commented on this pull request.
In js/carousel.js <#187 (comment)>:
> @@ -608,7 +623,7 @@
* @param {Function} callback
*/
_cycleTo(n, callback) {
- let diff = this.center % this.count - n;
+ let diff = (this.center % this.count) - n;
I think it should be fine because it is modulo and not divide operator.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#187 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA62YNMDEUXDKQJQ6CV5ILUCS3DZANCNFSM5EB664UA>.
|
DanielRuf
force-pushed
the
v1-dev
branch
2 times, most recently
from
6d71c21
to
e8384f5
Compare
|
Please see the failing commitlint check. We use commitlint-conventional: https://github.com/conventional-changelog/commitlint#what-is-commitlint So something like |
In the carousel, navigating by clicking : - at right when the selected item is the last - at left when the selected item is the first causes the clickedIndex to be invalid and breaks the component.
LoganTann
changed the title
… modified by my code editor this commit applies this review comment : #187 (comment)
…rt of the code fixes this commit applies this review comment : #187 (comment)
roiLeo
approved these changes
Oct 5, 2021
|
Sorry, I took too long to review, thanks for the PR and everyone that reviewed this PR 👍 Anyway, I sent an invitation to you to join the @materializecss/members team. Welcome 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the carousel, navigating by clicking :
causes the clickedIndex to be invalid and breaks the component.
Proposed changes
Solves #180 (and also Dogfalo#6459), all changes are explained here
Screenshots (if appropriate) or codepen:
see Dogfalo#6459 (comment)
Types of changes
Checklist:
I didn't tested nor created test because :
yarn test --verbose --filter=carouseltook way too much time in my laptop.