Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orjson and rate limiting changes #328

Merged
merged 6 commits into from
Jul 9, 2021
Merged

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Jul 9, 2021

This PR contains:

  • Changed input args to ReadOnlyResource to be commensurate with orjson inclusion in maggma.
  • Disabled client side rate limiting for endpoints other than api.materialsproject.org

@munrojm munrojm added the release:patch Patch release label Jul 9, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #328 (1bca698) into main (a219354) will decrease coverage by 0.34%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #328      +/-   ##
==========================================
- Coverage   89.45%   89.11%   -0.35%     
==========================================
  Files          59       59              
  Lines        1916     1920       +4     
==========================================
- Hits         1714     1711       -3     
- Misses        202      209       +7     
Impacted Files Coverage Δ
src/mp_api/core/ratelimit.py 100.00% <100.00%> (ø)
src/mp_api/routes/elasticity/client.py 72.72% <0.00%> (-21.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a219354...1bca698. Read the comment docs.

@munrojm munrojm merged commit d4097c5 into main Jul 9, 2021
@munrojm munrojm deleted the orjson_and_rate_limiting_changes branch July 9, 2021 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants