Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance output objects #654

Merged
merged 7 commits into from
Aug 12, 2022
Merged

Enhance output objects #654

merged 7 commits into from
Aug 12, 2022

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Aug 11, 2022

This PR introduces post-processing on returned document models to:

  • Remove unset attributes and add them to new fields_not_requested attribute
  • Add custom __repr__ and __str__ methods
  • Add custom attribute error for unset but available data

@munrojm munrojm added the release:minor Minor release bump label Aug 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2022

Codecov Report

Merging #654 (2b4092d) into main (ef951a2) will increase coverage by 0.31%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main     #654      +/-   ##
==========================================
+ Coverage   84.74%   85.06%   +0.31%     
==========================================
  Files          36       36              
  Lines        1501     1513      +12     
==========================================
+ Hits         1272     1287      +15     
+ Misses        229      226       -3     
Impacted Files Coverage Δ
src/mp_api/core/client.py 88.85% <66.66%> (+1.24%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@munrojm munrojm merged commit be24667 into main Aug 12, 2022
@munrojm munrojm deleted the enhancement/enhance_output_objects branch August 18, 2022 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:minor Minor release bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants