Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable nested monty decode for some data #784

Merged
merged 6 commits into from
Apr 27, 2023
Merged

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Apr 27, 2023

This PR disables monty decoding for nested objects in tasks and provenance to fix issues related to varying schema. Objects with types defined in the pydantic models are still instantiated for these endpoints.

@munrojm munrojm added the release:minor Minor release bump label Apr 27, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2023

Codecov Report

Patch coverage: 69.14% and project coverage change: -2.49 ⚠️

Comparison is base (98eb360) 81.05% compared to head (a4c0ce5) 78.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #784      +/-   ##
==========================================
- Coverage   81.05%   78.57%   -2.49%     
==========================================
  Files          36       38       +2     
  Lines        1758     1862     +104     
==========================================
+ Hits         1425     1463      +38     
- Misses        333      399      +66     
Impacted Files Coverage Δ
mp_api/client/core/utils.py 59.61% <0.00%> (ø)
mp_api/client/routes/_user_settings.py 100.00% <ø> (ø)
mp_api/client/routes/charge_density.py 67.16% <0.00%> (ø)
mp_api/client/routes/electronic_structure.py 88.81% <ø> (ø)
mp_api/client/routes/materials.py 68.57% <ø> (-7.15%) ⬇️
mp_api/client/routes/summary.py 94.82% <ø> (-1.73%) ⬇️
mp_api/client/routes/chemenv.py 23.25% <23.25%> (ø)
mp_api/client/routes/absorption.py 32.25% <32.25%> (ø)
mp_api/client/routes/alloys.py 52.63% <60.00%> (-6.20%) ⬇️
mp_api/client/mprester.py 59.13% <65.90%> (+0.33%) ⬆️
... and 27 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@munrojm munrojm merged commit d5190ff into main Apr 27, 2023
@munrojm munrojm deleted the bugfix/disable_monty branch August 30, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:minor Minor release bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants