Added Coverage #391
Open
Added Coverage #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we need to add a coverage token to this repo. |
Merged
|
Thanks @tschaume, can you have a look at this one for me? |
|
Looks like thinks should work once Ifermi is up to date with matplotlib. |
tschaume
added a commit
to tschaume/IFermi
that referenced
this pull request
May 24, 2024
See the [matplotlib changelog](https://matplotlib.org/stable/api/prev_api_changes/api_changes_3.9.0.html#top-level-cmap-registration-and-access-functions-in-mpl-cm) for 3.9.0. Using the `matplotlib.pyplot` should be backward-compatible. Merging this will allow @jmmshn to continue with materialsproject/crystaltoolkit#391
This was referenced May 24, 2024
|
@jmmshn I put in a PR with IFermi: fermisurfaces/IFermi#410 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added pytest coverage report.
Still need a coverage token to be set.
Updated requirements files
Some minor fixes to make sure all the tests passed after the requirements update.
get_cmapwas deprecated inmatplotlibphonopyis an option dependency ofpymatgenso it should be added during testing.