Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix get_cmap import #392

Merged
merged 2 commits into from
May 23, 2024
Merged

fix get_cmap import #392

merged 2 commits into from
May 23, 2024

Conversation

tschaume
Copy link
Member

matplotlib 3.9.0 removes matplotlib.cm.get_cmap but matplotlib.pyplot.get_cmap remains available for backward compatibility. See here. Just changing the import might work, but if not, we might have to change the logic to use the matplotlib.colormaps dict.

@tschaume tschaume requested a review from janosh May 22, 2024 18:48
@tschaume
Copy link
Member Author

Looks like using colormaps is already folded into #391. @jmmshn If your PR is tested, could you split this change from the "coverage" part in your PR? FYI @janosh

@tschaume tschaume merged commit dcd3c2f into main May 23, 2024
7 checks passed
@tschaume tschaume deleted the tschaume-patch-1 branch May 23, 2024 23:23
@tschaume tschaume mentioned this pull request May 24, 2024
Open
@jmmshn
Copy link
Collaborator

jmmshn commented May 24, 2024

Thanks @tschaume!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janosh janosh Awaiting requested review from janosh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tschaume @jmmshn