Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrationgraphdoc #437

Merged
merged 12 commits into from
Jul 12, 2022
Merged

Migrationgraphdoc #437

merged 12 commits into from
Jul 12, 2022

Conversation

hmlli
Copy link
Contributor

@hmlli hmlli commented Jun 16, 2022

Start with a description of this PR. Then edit the list below to the items that make sense for your PR scope, and check off the boxes as you go!

Contributor Checklist

  • I have broken down my PR scope into the following TODO tasks
    • add file for migrationgraphdoc
    • all functionalities added to migrationgraphdoc
  • I have run the tests locally and they passed.
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

@hmlli
Copy link
Contributor Author

hmlli commented Jun 27, 2022

@munrojm Hi Jason! Do I need to add a test to this? If so, is there a good example test file that I can go off of? If not, I believe it's ready for review! Thanks!

@munrojm
Copy link
Member

munrojm commented Jun 27, 2022

Hey @hmlli! Thanks for the PR! Left one comment.

As for tests, you should add one to test the class method attached to the doc model. Here are the tests for the electrode-related document models for example: https://github.com/materialsproject/emmet/blob/main/tests/emmet-core/test_electrodes.py.

@hmlli
Copy link
Contributor Author

hmlli commented Jun 28, 2022

hi @munrojm, I've finished adding the test, this PR should be ready for review. Thanks :)

@hmlli hmlli changed the title [WIP] Migrationgraphdoc Migrationgraphdoc Jun 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2022

Codecov Report

Merging #437 (b81830b) into main (9bdea4e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #437   +/-   ##
=======================================
  Coverage   97.67%   97.67%           
=======================================
  Files         114      115    +1     
  Lines       23837    23856   +19     
=======================================
+ Hits        23283    23302   +19     
  Misses        554      554           
Impacted Files Coverage Δ
emmet-core/emmet/core/mobility/migrationgraph.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c10430...b81830b. Read the comment docs.

@hmlli
Copy link
Contributor Author

hmlli commented Jul 11, 2022

@munrojm I have merged changes from main and should be OK to merge. Let me know if any further edits are needed!

@munrojm
Copy link
Member

munrojm commented Jul 11, 2022

@hmlli sounds good! Last thing is just addressing the comment I left above regarding the try-except block. After that is changed, I will merge.

@munrojm munrojm merged commit 81b856e into materialsproject:main Jul 12, 2022
@hmlli hmlli deleted the migrationgraphdoc branch July 13, 2022 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants