Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Migration Graph Builder #468

Merged
merged 18 commits into from Aug 1, 2022

Conversation

acrutt
Copy link
Contributor

@acrutt acrutt commented Jul 21, 2022

Adding a new MapBuilder to create migration graphs from an InsertionElectrode collection. Based on MigrationGraphDoc developed by @hmlli in #437

@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2022

Codecov Report

Merging #468 (98b71e6) into main (c01c332) will decrease coverage by 0.02%.
The diff coverage is 83.72%.

@@            Coverage Diff             @@
##             main     #468      +/-   ##
==========================================
- Coverage   97.61%   97.58%   -0.03%     
==========================================
  Files         115      116       +1     
  Lines       24011    24054      +43     
==========================================
+ Hits        23438    23474      +36     
- Misses        573      580       +7     
Impacted Files Coverage Δ
emmet-core/emmet/core/mobility/migrationgraph.py 94.91% <ø> (ø)
...uilders/emmet/builders/mobility/migration_graph.py 83.72% <83.72%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@acrutt acrutt changed the title [WIP] Add Migration Graph Builder Add Migration Graph Builder Jul 27, 2022
@munrojm
Copy link
Member

munrojm commented Jul 27, 2022

Thanks @acrutt and @hmlli !!

I remember @hmlli originally having a try-except block in a document construction method. If document construction failure is possible, but the desire is to exclude the failure and keep processing, then a try-except block should be added to the builder processing method.

@acrutt acrutt changed the title Add Migration Graph Builder [WIP] Add Migration Graph Builder Jul 28, 2022
@acrutt acrutt changed the title [WIP] Add Migration Graph Builder Add Migration Graph Builder Aug 1, 2022
@acrutt
Copy link
Contributor Author

acrutt commented Aug 1, 2022

@munrojm I finished updating the builder after @hmlli latest changes to the MigrationGraphDoc. I think this is ready to merge unless you have any suggested edits!

@munrojm munrojm merged commit 345c8e5 into materialsproject:main Aug 1, 2022
@acrutt acrutt deleted the migration_graph_builder branch August 4, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants