Merge pull request #815 from materialsproject/bugfix/store_conn

Check for collection before closing in resources

src/maggma/api/resource/post_resource.py

@@ -144,8 +144,8 @@ def search(**queries: Dict[str, STORE_PARAMS]) -> Dict:
                         detail="Server timed out trying to obtain data. Try again with a smaller request, "
                         "or remove sorting fields and sort data locally.",
                     )
-
-            self.store.close()
+            if self.store._coll:
+                self.store.close()
 
             operator_meta = {}
 

src/maggma/api/resource/read_resource.py

@@ -168,7 +168,8 @@ def get_by_key(
                     detail=f"Item with {self.store.key} = {key} not found",
                 )
 
-            self.store.close()
+            if self.store._coll:
+                self.store.close()
 
             for operator in self.query_operators:
                 item = operator.post_process(item, {})
@@ -275,7 +276,8 @@ def search(**queries: Dict[str, STORE_PARAMS]) -> Union[Dict, Response]:
                         " or remove sorting fields and sort data locally.",
                     )
 
-            self.store.close()
+            if self.store._coll:
+                self.store.close()
 
             operator_meta = {}
 

src/maggma/api/resource/s3_url.py

@@ -114,7 +114,8 @@ def get_by_key(
                     ),
                 )
 
-            self.store.close()
+            if self.store._coll:
+                self.store.close()
 
             requested_datetime = datetime.utcnow()
             expiry_datetime = requested_datetime + timedelta(seconds=self.url_lifetime)

src/maggma/api/resource/submission.py

@@ -174,7 +174,8 @@ def get_by_key(
                     detail=f"Item with submission ID = {key} not found",
                 )
 
-            self.store.close()
+            if self.store._coll:
+                self.store.close()
 
             for operator in self.get_query_operators:  # type: ignore
                 item = operator.post_process(item, {})
@@ -257,7 +258,8 @@ def search(**queries: STORE_PARAMS):
                         "or remove sorting fields and sort data locally.",
                     )
 
-            self.store.close()
+            if self.store._coll:
+                self.store.close()
 
             meta = Meta(total_doc=count)