Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for collection before closing in resources #815

Merged
merged 1 commit into from Jul 6, 2023
Merged

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Jul 6, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch coverage: 83.33% and project coverage change: -0.01 ⚠️

Comparison is base (4675761) 88.12% compared to head (f7cc1cb) 88.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #815      +/-   ##
==========================================
- Coverage   88.12%   88.11%   -0.01%     
==========================================
  Files          44       44              
  Lines        3630     3636       +6     
==========================================
+ Hits         3199     3204       +5     
- Misses        431      432       +1     
Impacted Files Coverage Δ
src/maggma/api/resource/s3_url.py 56.86% <0.00%> (-1.14%) ⬇️
src/maggma/api/resource/post_resource.py 90.16% <100.00%> (+0.16%) ⬆️
src/maggma/api/resource/read_resource.py 86.36% <100.00%> (+0.25%) ⬆️
src/maggma/api/resource/submission.py 81.13% <100.00%> (+0.24%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@munrojm munrojm merged commit 64df9f3 into main Jul 6, 2023
9 of 11 checks passed
@munrojm munrojm deleted the bugfix/store_conn branch July 6, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant