Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix API Sanitizing MSONable types in combined types #454

Merged
merged 5 commits into from
Jun 18, 2021
Merged

Conversation

shyamd
Copy link
Contributor

@shyamd shyamd commented Jun 18, 2021

This should fix the issue where MSONable types in a combined type such as Union and Dict were not being properly sanitized for the API.

@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #454 (fc970c1) into main (09ac770) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #454      +/-   ##
==========================================
+ Coverage   88.21%   88.24%   +0.03%     
==========================================
  Files          40       40              
  Lines        2604     2611       +7     
==========================================
+ Hits         2297     2304       +7     
  Misses        307      307              
Impacted Files Coverage Δ
src/maggma/api/query_operator/sparse_fields.py 97.05% <ø> (ø)
src/maggma/core/store.py 86.27% <ø> (ø)
src/maggma/api/API.py 80.48% <100.00%> (ø)
src/maggma/api/query_operator/__init__.py 100.00% <100.00%> (ø)
src/maggma/api/query_operator/dynamic.py 94.28% <100.00%> (-0.09%) ⬇️
src/maggma/api/query_operator/pagination.py 88.88% <100.00%> (ø)
src/maggma/api/query_operator/sorting.py 83.33% <100.00%> (ø)
src/maggma/api/query_operator/submission.py 95.45% <100.00%> (ø)
src/maggma/api/resource/__init__.py 100.00% <100.00%> (ø)
src/maggma/api/resource/aggregation.py 94.28% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update febc0b3...fc970c1. Read the comment docs.

@shyamd shyamd merged commit a7b14a4 into main Jun 18, 2021
@munrojm munrojm deleted the api_sanitize_bug branch November 10, 2021 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant