Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pynng functionality with pyzmq #543

Merged
merged 15 commits into from
Jan 26, 2022
Merged

Replace pynng functionality with pyzmq #543

merged 15 commits into from
Jan 26, 2022

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Jan 25, 2022

This PR replaces Pair1 use from pynng with a REP/REQ server-client setup from pyzmq. This hopefully fixes issues with maggma and new Apple M1 chips.

@lgtm-com
Copy link

lgtm-com bot commented Jan 25, 2022

This pull request introduces 2 alerts when merging 39a0b5f into d7d93f0 - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Wrong number of arguments in a call

@codecov
Copy link

codecov bot commented Jan 25, 2022

Codecov Report

Merging #543 (250d25a) into main (b14a5b2) will increase coverage by 0.09%.
The diff coverage is 98.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #543      +/-   ##
==========================================
+ Coverage   89.02%   89.12%   +0.09%     
==========================================
  Files          40       40              
  Lines        2743     2768      +25     
==========================================
+ Hits         2442     2467      +25     
  Misses        301      301              
Impacted Files Coverage Δ
src/maggma/cli/__init__.py 87.27% <75.00%> (+0.23%) ⬆️
src/maggma/cli/distributed.py 100.00% <100.00%> (ø)
src/maggma/cli/multiprocessing.py 94.59% <100.00%> (ø)
src/maggma/core/drone.py 92.42% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfd881f...250d25a. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Jan 25, 2022

This pull request introduces 2 alerts when merging b800d24 into d7d93f0 - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Wrong number of arguments in a call

@lgtm-com
Copy link

lgtm-com bot commented Jan 25, 2022

This pull request introduces 1 alert when merging b234f07 into d7d93f0 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

@lgtm-com
Copy link

lgtm-com bot commented Jan 26, 2022

This pull request introduces 1 alert when merging 65ccef6 into d7d93f0 - view on LGTM.com

new alerts:

  • 1 for Unused import

@munrojm munrojm changed the title [WIP] Replace pynng functionality with pyzmq Replace pynng functionality with pyzmq Jan 26, 2022
@munrojm munrojm merged commit 309df0e into main Jan 26, 2022
@munrojm munrojm deleted the zero_mq branch February 15, 2022 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant